Decouple TestVerify into TestValidateBasic and TestVerify#1231
Merged
Manav-Aggarwal merged 2 commits intomainfrom Oct 6, 2023
Merged
Decouple TestVerify into TestValidateBasic and TestVerify#1231Manav-Aggarwal merged 2 commits intomainfrom
Manav-Aggarwal merged 2 commits intomainfrom
Conversation
Manav-Aggarwal
added
T:testing
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
- Coverage 53.98% 53.79% -0.20%
==========================================
Files 64 64
Lines 7020 7012 -8
==========================================
- Hits 3790 3772 -18
- Misses 2872 2881 +9
- Partials 358 359 +1
☔ View full report in Codecov by Sentry. |
Contributor
|
this is based on #1228 right? can we target that branch to reduce the diff or just make this as draft? there are comments on the other PR that I don't want to duplicate. |
Manav-Aggarwal
force-pushed
the
manav/refactor_signed_header_test
branch
from
e585ea9 to
f275f55
Compare
Member
Author
Manav-Aggarwal
force-pushed
the
manav/refactor_signed_header_test
branch
from
f275f55 to
50733c7
Compare
MSevey
reviewed
Oct 5, 2023
MSevey
reviewed
Oct 5, 2023
Contributor
MSevey
left a comment
MSevey
left a comment
There was a problem hiding this comment.
minor test util improvement, otherwise lgtm
S1nus
approved these changes
Oct 5, 2023
MSevey
approved these changes
Oct 6, 2023
chandiniv1
pushed a commit
to chandiniv1/rollkit
that referenced
this pull request
Oct 19, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Closes: evstack#1189 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
gupadhyaya
pushed a commit
that referenced
this pull request
Oct 20, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Closes: #1189 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes: #1189
Checklist